Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Simultaneous support of Trezor and Ledger HD wallets #252

Merged
merged 9 commits into from
Jan 30, 2019

Conversation

vbaranov
Copy link
Collaborator

Problem: On switching from one HD wallet to another, for example, switching from Ledger to Trezor or vise-versa, accounts from forgotten HD device are automatically lost in the list of imported accounts.

Solution: This PR switches on the simultaneous support of Trezor and Ledger HD wallets. It means, that users will be able to work in Nifty wallet with Ledger and Trezor accounts simultaneously.

How simultaneous support of Trezor/Ledger will work:
When you are switching from one HD device to another, you should click Forget this device, as usual. The new thing, that is introduced in this PR, that the confirmation page will be opened with the checkbox Are you sure you want to forget this Ledger/Trezor?. It will be unchecked by default.

  • if checkbox will be unchecked, then accounts from forgotten device will not be removed from the imported accounts list. And users will be able to operate from these accounts (send transactions, interact with smart-contracts etc).
  • if checkbox will be checked, then accounts from forgotten will be removed, as it worked before this PR.

How confirmation page looks like:

screenshot 2019-01-28 at 17 53 28

Built on top of #250

@vbaranov vbaranov merged commit dbafb66 into develop Jan 30, 2019
@vbaranov vbaranov deleted the trezor-ledger branch January 30, 2019 12:06
@ghost ghost removed the awaiting for review label Jan 30, 2019
@vbaranov vbaranov mentioned this pull request Feb 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants