Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gas price for RSK #292

Merged
merged 14 commits into from
Jun 12, 2019
Merged

Fix gas price for RSK #292

merged 14 commits into from
Jun 12, 2019

Conversation

vbaranov
Copy link
Collaborator

@vbaranov vbaranov commented Jun 11, 2019

Built on top of #291

RSK chain has a lot of transactions between empty addresses with an empty gas price like this https://blockscout.com/rsk/mainnet/tx/0x225969fd0b906fa6ae23190d26bac7ece2aa02410f4626c6612dce85c30b605a/internal_transactions. We should exclude such transactions from gas price calculation.

@vbaranov vbaranov requested a review from patitonar June 11, 2019 16:04
@vbaranov vbaranov changed the title Fix gas price fro RSK Fix gas price for RSK Jun 11, 2019
Copy link

@patitonar patitonar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once errors from ci/circleci: test-e2e-chrome and ci/circleci: test-lint are fixed, we can merge this

@vbaranov vbaranov merged commit 8a21664 into develop Jun 12, 2019
@vbaranov vbaranov deleted the fix-gas-price branch June 12, 2019 13:32
@vbaranov vbaranov mentioned this pull request Jun 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants