Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Add warning and pause deployment if user accidentally change MetaMask account while deployment #647

Closed
dennis00010011b opened this issue Mar 1, 2018 · 1 comment · Fixed by #680
Assignees

Comments

@dennis00010011b
Copy link

dennis00010011b commented Mar 1, 2018

Inspired by https://poanetwork.slack.com/archives/G8HRTP6JZ/p1519910256000437

Problem:

if user accidentally change the metamask account while deployment the deployment continues, option "skip transaction" is available for next 3-4 transaction and deployment freezes even if user returns back to right account.

Possible solution:

  1. Should be warning : "Not owner. Unable to continue ..........etc."
  2. Deployment should be paused until user switches to right Metamask account.

If you are reporting a problem with Token Wizard, please include the following information:

Which network did you use? (Mainnet, Kovan, Rinkeby, etc.)

Rinkeby

If you were able to create it, what is the URL of your crowdsale?

https://wizard.poa.network/invest?addr=0x719c2571Af05B64a8c8f17E69c7720BC727368AD&networkID=4

Do you have screenshots showing the problem?

https://drive.google.com/open?id=1NNIZsGv3hZMzmXRIk9tdg_90zBErkpjs

Do you see errors in the dev console? If yes, please include a screenshot

To open the dev console in Google Chrome, press F12, or go to View -> Developer -> Developer Tools, and open the Console tab

If you see errors, please right click on them and "Save as..". Zip saved file and attach it to the Issue.

No


@fvictorio
Copy link
Contributor

This issue and #593 may be related. The problem is not the same, but the solution is similar (handling metamask events). See my comment there for a possible approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants