Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Feature) Warning on account switch #685

Merged
merged 10 commits into from
Mar 16, 2018
Merged

Conversation

fvictorio
Copy link
Contributor

@fvictorio fvictorio commented Mar 13, 2018

Depends on #680. Closes #647.

Demo

This only happens in the deployment modal. You can switch accounts if the deploy didn't start yet.

@fvictorio fvictorio force-pushed the warning-on-account-switch-#647 branch from b95fdc5 to ee07df5 Compare March 13, 2018 20:04
@fvictorio fvictorio changed the title Warning on account switch (Feature) Warning on account switch Mar 13, 2018
@coveralls
Copy link

coveralls commented Mar 13, 2018

Pull Request Test Coverage Report for Build 1748

  • 0 of 26 (0.0%) changed or added relevant lines in 4 files are covered.
  • 82 unchanged lines in 2 files lost coverage.
  • Overall coverage increased (+0.2%) to 15.792%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/IncompleteDeploy.js 0 2 0.0%
src/stores/DeploymentStore.js 0 6 0.0%
src/utils/cancelDeploy.js 0 8 0.0%
src/components/stepFour/index.js 0 10 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/stepFour/index.js 20 0.0%
src/components/manage/utils.js 62 0.0%
Totals Coverage Status
Change from base Build 1726: 0.2%
Covered Lines: 388
Relevant Lines: 1930

💛 - Coveralls

@fvictorio
Copy link
Contributor Author

@dennis00010011b Can you check if the failing e2e scenarios are correct, or if the problem is with the tests?

Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fvictorio how could I repeat it? I have never seen warning on switching accounts in my tests:

ezgif com-video-to-gif 2

@fvictorio
Copy link
Contributor Author

fvictorio commented Mar 15, 2018

You are right, it doesn't seem to be working now. Maybe some merge broke it. I will take a look.

@fvictorio
Copy link
Contributor Author

@vbaranov It should be working now.

I also fixed two unrelated issues:

  • The reload wasn't working anymore: if you refreshed the page, it would re-start the deploy from the first transaction.
  • If you switched accounts, and then refreshed, the deploy would resume with the invalid account. The only issue with this is that in this case you have to switch to the correct account and then restart again for the deploy to continue.

@vbaranov vbaranov merged commit 12a76d8 into master Mar 16, 2018
@ghost ghost removed the awaiting for review label Mar 16, 2018
@vbaranov vbaranov deleted the warning-on-account-switch-#647 branch March 16, 2018 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants