-
Notifications
You must be signed in to change notification settings - Fork 216
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
(Bug) Keep data between the steps (Step 4 - Publish && Step 5 - Contribution Page) #1097
Conversation
Pull Request Test Coverage Report for Build 2926
💛 - Coveralls |
@mariano-aguero
Expected result:
Actual result:
|
@mariano-aguero
Actual result:
https://www.useloom.com/share/bca7bd600b6d406b9c13bcb70c28ac0a |
03ed70c
to
2cc00cc
Compare
Done in this branch How to reproduce it:
|
2cc00cc
to
a2f00f6
Compare
Fixed |
@mariano-aguero |
@mariano-aguero |
@mariano-aguero
|
32b1fe3
to
9b95043
Compare
An additional tier no longer appears https://www.useloom.com/share/56c9e4fbb6ea4f748fafb2b9405e8ca2 |
Change alert |
Speaking with @fernandomg , we thought that the user should cancel the previous transaction (reject). The solution to this problem would imply a very high programming cost which I do not think is the time to face. I think we could create an issue for it and work it after the design application, Do you agree? |
@mariano-aguero Ok,I agree. I'll create an issue |
@mariano-aguero User able to finish deployment without signing all transactions
Actual result:
Possible solution:
|
1df444a
to
8f2edde
Compare
I apply the solution in Step 4 disable button continue if not all transaction signed Can you check it ? Thanks |
53c8d5d
to
00573db
Compare
00573db
to
24e45ab
Compare
@dennis00010011b
Can you check this two steps with this branch?
I Perform some tests and it seems to work well, I would need your expert eye
Thanks in advance