Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Bug) Keep data between the steps (Integration Branch) #1104

Merged
merged 176 commits into from Sep 4, 2018

Conversation

mariano-aguero
Copy link
Contributor

@mariano-aguero mariano-aguero commented Aug 22, 2018

This is a PR with an integration branch
Closes #1033

Pull request covering the steps

Once the steps are merged, an integral test would have to be carried out

@dennis00010011b
Copy link

Hi @mariano-aguero

I change how validate the supply input, Regards

It fixed

@fernandomg
Copy link
Contributor

Before merging/approving this PR, this must be solved: #1103 (comment)

@mariano-aguero
Copy link
Contributor Author

@dennis00010011b

Before merging/approving this PR, this must be solved: #1103 (comment)

Can you check de fix for the above comment? Thanks

@dennis00010011b
Copy link

@mariano-aguero
it fixed #1103 (comment)

@dennis00010011b
Copy link

dennis00010011b commented Sep 3, 2018

@mariano-aguero
Contribution page: app crashed if network switched
Steps:

  1. Set network Sokol
  2. Create Minted (or Dutch) crowdsale with any valid parameters
  3. Open contribution page as an owner
  4. Set network Rinkeby(or any other)
  5. Confirm warning, observe page.

Expected result:
-warning should be displayed 'switch to Sokol network .........'
Actual result :

  • app crashed, error message

screen shot 2018-09-03 at 3 50 28 am

contrib_grash.log

@mariano-aguero
Copy link
Contributor Author

@dennis00010011b

Contribution page: app crashed if network switched

I change how network is validated, separate it from the rest of the environment check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants