Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Fix) Metamask not being called #654

Merged
merged 32 commits into from
Mar 13, 2018
Merged

Conversation

fernandomg
Copy link
Contributor

Closes #632

  • Created BigNumberInput component
  • Refactored stepTwo, to use CrowdsaleBlock for all the tiers
  • Refactored CrowdsaleBlock component
  • Added tests

@ghost ghost assigned fernandomg Mar 5, 2018
@ghost ghost added the in progress label Mar 5, 2018
@coveralls
Copy link

coveralls commented Mar 5, 2018

Pull Request Test Coverage Report for Build 1618

  • 76 of 138 (55.07%) changed or added relevant lines in 10 files are covered.
  • 7 unchanged lines in 3 files lost coverage.
  • Overall coverage increased (+4.4%) to 14.371%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/components/Common/BigNumberInput.js 41 42 97.62%
src/components/stepThree/CrowdsaleBlock.js 23 24 95.83%
src/components/crowdsale/utils.js 0 1 0.0%
src/components/manage/utils.js 0 3 0.0%
src/stores/utils.js 0 5 0.0%
src/components/crowdsale/index.js 0 22 0.0%
src/components/stepThree/index.js 0 29 0.0%
Files with Coverage Reduction New Missed Lines %
src/components/Common/WhitelistInputBlock.js 1 25.64%
src/stores/utils.js 1 0.0%
src/components/stepThree/index.js 5 0.0%
Totals Coverage Status
Change from base Build 1612: 4.4%
Covered Lines: 351
Relevant Lines: 1930

💛 - Coveralls

Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier name is empty in ./manage page:

screen shot 2018-03-05 at 22 53 35

const currentTime = '2018-03-05T11:00:00'
const { INVALID } = VALIDATION_TYPES

MockDate.set(currentTime)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how jest tests are run. Should this be in a beforeAll? Should the afterAll function call a restore?

(If each jest spec is run independently, this may not be necessary, but I'm not really sure about that.)

@ghost ghost assigned vbaranov Mar 11, 2018
@vbaranov vbaranov self-requested a review March 11, 2018 20:25
Copy link
Collaborator

@vbaranov vbaranov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tier 2 is not editable from ./manage page, but it actually is editable (there is no such bug in master branch):

screencapture-deploy-preview-654-ico-wizard-netlify-manage-0x0bf3aca057090e7856a0cff7a61adcb1d3d8ca3b-2018-03-11-23_24_58

@fernandomg
Copy link
Contributor Author

@vbaranov I just merged from master, and it's working fine:

screen shot 2018-03-12 at 11 37 12-fullpage

@vbaranov vbaranov self-requested a review March 13, 2018 12:30
@vbaranov vbaranov merged commit 28b179e into master Mar 13, 2018
@ghost ghost removed the awaiting for review label Mar 13, 2018
@vbaranov vbaranov deleted the metamask-not-being-called-#632 branch March 13, 2018 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants