Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow an indicator when station has been offline and data are stale #218

Closed
tomdotorg opened this issue Oct 20, 2019 · 5 comments
Closed
Milestone

Comments

@tomdotorg
Copy link
Contributor

Having just had a few issues recently with network and power, each of which knocking my station offline, I noticed that my Belchertown skin does not provide any kind of visual indicator to let a user know that the conditions they are looking at are 12+ hours old.

I think it would be good to be able to set a threshold of time after which we tell users that the data are old.

@poblabs
Copy link
Owner

poblabs commented Oct 20, 2019

I recently experienced this as well so it's on my list. What I struggle with is a nice way to show that. When you use the MQTT Websockets the status bar is taken over by the MQTT server providing the dateTime field. I suppose I could prepend that line with "Last Updated: MM/DD/YYYY HH:SS" then clear that once MQTT provides the dateTime? Too many characters in that line also affect mobile visitors too. Thoughts?

@tomdotorg
Copy link
Contributor Author

I love the idea of letting users know when the info on the page was last updated when the MQTT connection is inactive or when there has been an amount of time since we last had an archive record come in.

Thanks for looking at this!

@tomdotorg
Copy link
Contributor Author

Come to think of it, maybe the text always shows 'as of: ' and we give them the MQTT or most recent raw or archive?

@poblabs
Copy link
Owner

poblabs commented Oct 21, 2019

Not a bad idea. Will be a breaking change to those who have translated the skin, but I can put that in the changelog. Need to think of a good presentation for it.

poblabs added a commit that referenced this issue Oct 23, 2019
Fixes #218

Updates #104 for translation key changes
@poblabs
Copy link
Owner

poblabs commented Oct 23, 2019

This is committed now to development and will be in the release for 1.1

@poblabs poblabs closed this as completed Oct 23, 2019
@poblabs poblabs added this to the 1.1 milestone Oct 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants