Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translation #104

Closed
olpayras opened this issue Apr 22, 2019 · 208 comments
Closed

Translation #104

olpayras opened this issue Apr 22, 2019 · 208 comments
Milestone

Comments

@olpayras
Copy link

I used skin.conf to translate your skin in french. There are very few fields who stay in english. Here are them.

Main Page

Records

@poblabs
Copy link
Owner

poblabs commented Apr 22, 2019

Those get changed in weewx.conf under Labels > Generic. That is a weewx wide setting.

@poblabs poblabs closed this as completed Apr 22, 2019
@poblabs
Copy link
Owner

poblabs commented Apr 22, 2019

Oops I didn't see the word "ending" and "days". I will update that soon.

Barometer, dew point, etc. are in weewx.conf Labels

@poblabs poblabs reopened this Apr 22, 2019
@poblabs poblabs added this to the 1.0 milestone Apr 22, 2019
@olpayras
Copy link
Author

olpayras commented Apr 22, 2019

Also in the first picture : "Updated on" is also written in index.html.tmpl

// MQTT Websockets not enabled, update the Last Updated timestamp with moment.js
            updated = moment.unix( $current.dateTime.raw ).utcOffset($moment_js_utc_offset).format("LL, LTS");
            updated_text = "**Last Updated** " + updated;
            jQuery(".updated").html( updated_text );
            #end if

When i change bold value it translate.

@bonjour81
Copy link
Contributor

bonjour81 commented Apr 24, 2019

@olpayras , I would be happy to see your work, I also work on a french version 👍
mine is now online here

Oh my god, nous sommes voisins :)

@olpayras
Copy link
Author

olpayras commented Apr 25, 2019

Hi bonjour81,

Yes we are "voisins". I just translated it to see what wasn't translated. It's not perfect. My station including history feature is here.

My fork for french translation is here too

Have a good day.

Olivier.

@bonjour81
Copy link
Contributor

Merci @olpayras ! I improved a few translations based on yours.
My version is here (translation branch).
feel free to contact me if you like to discuss about it (I have a twitter link on my profile). Here is not the place for discussions about translations :)

@HoracioDos
Copy link

Hello!
It would be a good opportunity to translate into spanish too. I'm a little worried about the page layout. Latin derived languages seems to have longer words, at least in spanish compared to english. I wouldn't like to modify the style sheet to make room for them.

@olpayras
Copy link
Author

olpayras commented Apr 25, 2019

Yes words are longer in latin derived languages. Anyway, you can truncate some too long words, but I didn't. French has very long words too. You can check on my page. I understand little spanish cause i'm not very far from spain, but cannot help you for translation, cause my spanish writing is too poor.

@bonjour81, I have no twitter account but have skype account, so we can share ideas for translations or anyelse. My skype account is my nickname here.

@HoracioDos
Copy link

Hello Pat
I updated to version 1.0RC7 last night and I began to translate into spanish. Station max and min temp labels are the same for snapshots max and min temp. I think it could be better if they are separated. Keywords are "high" and "low" in skin.conf
Thanks!

@bonjour81
Copy link
Contributor

Hello @poblabs ,
I would like to report a missing key for translation.
On record page, just right to "Consecutive Days With Rain" & "Consecutive Days Without Rain", there is "ending".
I think "ending" has no translation key in skin.conf.
By the way, is there any reason that the construction of this part is different to "all time" on same line ? (no "ending" for alltime).

ending

@bonjour81
Copy link
Contributor

Same place (juste left to red marking), it is also "days" that is hard coded.
There is a coding for day/days (week, weeks etc...) in weewx.conf..maybe we can use this ?

@olpayras
Copy link
Author

olpayras commented Apr 26, 2019

Hi Bonjour81,

I already reported these mistakes on the first post of this topic. Pat told me, he will update this file sooner. I don't think it's a good idea to use weewx.conf cause when there is major weewx update, weewx.conf is rewritten and our translations will disappear. I already have an issue when translating wind directions, changing W by O. So now, I try to not translate this file when possible.

@poblabs
Copy link
Owner

poblabs commented Apr 26, 2019

Yes this has been reported. I have not gotten to it yet - have been busy and have had no time to work on this since this is just a hobby.

Your assumption is also incorrect. Put all overrides in weewx.conf.

skin.conf gets overwritten on skin upgrades.

poblabs added a commit that referenced this issue Apr 27, 2019
@poblabs
Copy link
Owner

poblabs commented Apr 27, 2019

Latest commit should close this one out.

@poblabs poblabs closed this as completed Apr 27, 2019
poblabs added a commit that referenced this issue Apr 27, 2019
poblabs added a commit that referenced this issue Apr 27, 2019
@poblabs
Copy link
Owner

poblabs commented Apr 27, 2019

@HoracioDos I just separated out those high/low areas too. Should be all set now for you to translate them

@bonjour81
Copy link
Contributor

Sorry for double report!!! :( I guess I was too tired to think straight

@HoracioDos
Copy link

@HoracioDos I just separated out those high/low areas too. Should be all set now for you to translate them

Thank again Pat.

@HoracioDos
Copy link

Hello Pat.
I synched your last commits (apr 27) and everything works fine with the new tags. I translated moon phases names and now the icon is missing in Sun & Moon. I think that I missed to config something else. Any hint?
Thanks!

@poblabs
Copy link
Owner

poblabs commented Apr 27, 2019

@HoracioDos Hmm. this will be interesting. The moon icon is hard set. It gets the data from moon_phases and compares it to the almanac. So in order for that to work I wonder if I need to add a label for each moon phase, which will then be compared against moon_phases? Seems redundant though.

@poblabs poblabs reopened this Apr 27, 2019
@HoracioDos
Copy link

Yes, I agree. It seems redundant, but if you have multiple skins, belchertown tags won't be affected if you have your own moon phases names.
I found that Moon-container is duplicated in style.css

.moon-container {
	font-size:15px;
}
.moon-container {
	color:#808080;
}

@bonjour81
Copy link
Contributor

bonjour81 commented Apr 28, 2019

@HoracioDos : did you translate moon phases in weewx.conf too ?
I did this before, but I think it's what the skin uses to find the right icon. it shall stay in english here.
I mean in weewx.conf in:

[StdReport]
    [[Defaults]]   
             [[[Almanac]]]

english moon phases in weewx.conf but french in skin.conf (in [almanach] works for me.

@olpayras
Copy link
Author

olpayras commented Apr 28, 2019

I only translate weewx.conf, and its ok for me.

In french :

[[[Almanac]]]

            # The labels to be used for the phases of the moon:
            moon_phases = Nouvelle, Croissante, Premier quartier, Gibbeuse croissante, Pleine, Gibbeuse décroissante, Dernier Quartier, Décroissante

@olpayras
Copy link
Author

@salinois

Also, if you don't want bad data again, check that if not done : http://weewx.com/docs/usersguide.htm#StdQC else you can have new bad datas coming if the sensor give bad values.

@HoracioDos
Copy link

Oh, I didn't check your commit. A width will force the 49% even on mobile. try max-width: 49% - that may help you?

min-width: 49% worked best for both situations. There is no need to break labels now.
HoracioDos@287c42c
almanac

@salinois
Copy link

@olpayras
bonjour, pas trop compris ta réponse !!!
patrick

poblabs added a commit that referenced this issue May 28, 2019
Updates #104 for some new keys

Updates #65 - still not sure how to make this space dynamic but at least this commit removes UV which not everyone has.
@norecords
Copy link
Contributor

norecords commented May 28, 2019

@salinois
What's @olpayras means that you have to set min/max values of sensors in stdQC section in weewx.conf to avoid any future wrong values.
For your example

[StdQC]
   [[MinMax]]
      ...
      soilTemp1 = -20, 50
      ...

That mean acceptable values for soilTemp1 are between -20° and +50° otherwise it will ignore the value.

@salinois
Copy link

OK, I understood
I will do that
thanks
Patrick

@HoracioDos
Copy link

Hello Pat
I added rc9.3 new labels and changed a few more in skin.conf.es. All of them are ok for mobile.
HoracioDos@914c03c

@poblabs
Copy link
Owner

poblabs commented May 31, 2019

I think we're in the final phase for a 1.0 release. I'll be performing last round of installation testing and validation but I think it's ready to go. Closing this. Re-open if you find any other hard coded translation items that need to be fixed in a future version.

@poblabs poblabs closed this as completed May 31, 2019
poblabs added a commit that referenced this issue May 31, 2019
poblabs added a commit that referenced this issue May 31, 2019
Updates #104 for some new keys

Updates #65 - still not sure how to make this space dynamic but at least this commit removes UV which not everyone has.
@poblabs
Copy link
Owner

poblabs commented Jun 10, 2019

To all here: I am working on 1.1 beta release - it is in the development branch. I just pushed a big update which removes the need for belchertown_root_url. You all are good testers - so please test this out when you have a chance and start a new issue if you find problems. Thanks!

@olpayras
Copy link
Author

Ok, Pat, I will install it tomorrow. Now it's late here.

@olpayras
Copy link
Author

Installed on my dev site, no issue for the moment. I'll put it on my master weather site, in the next days.

@salinois
Copy link

salinois commented Jun 13, 2019 via email

@olpayras
Copy link
Author

PI page seems hardcoded. Perhaps, sould we use same labels than other pages.

Capture

@poblabs
Copy link
Owner

poblabs commented Jun 27, 2019

@olpayras Yep, the Pi page was a little neglected during the 1.0 upgrade. In 1.1 I'm planning on getting it updated. These could be quick fixes for me, so I'll try to get those labels in place today in the development branch.

poblabs added a commit that referenced this issue Jun 27, 2019
@poblabs
Copy link
Owner

poblabs commented Jun 27, 2019

@olpayras I've updated it. Feel free to test. The wind direction is identical to the main page - it should be getting that from your weewx.conf and not a translation label - so make sure you have that ESE changed there.

@olpayras
Copy link
Author

Translated now :

image

Miss : today max.

I'll check when Wind direction will be from W..., it's the only ordinate that change in latin languages.

@poblabs
Copy link
Owner

poblabs commented Jun 27, 2019

@olpayras Nope, today max is a new key in skin.conf 😄 You will need to add that to your translations.

See the commit notes: 7febc1d#diff-8b2c495116c77b064b8249b6556e2ea5L166

@olpayras
Copy link
Author

Oups, sorry. I'll change that.

Another thing, date format from connect to weather station sould be same than main page if possible. Is this new in skin.conf too ?

@poblabs
Copy link
Owner

poblabs commented Jun 27, 2019

It should be the same. I wonder if I missed it. Can you send the screenshot?

poblabs added a commit that referenced this issue Jun 28, 2019
Updates #104 for a new key
Updates #182
poblabs added a commit that referenced this issue Aug 26, 2019
Updates #195

Updates #104 for a new translation key
poblabs added a commit that referenced this issue Oct 23, 2019
Fixes #218

Updates #104 for translation key changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants