Validate integer-like string arguments early and throw sensible errors. #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a number of arguments that are strings in JMAP and integers in the database, such as id fields, and sinceState. These weren't being validated and would throw db exceptions if non-integer data was passed in.
wolfsage
force-pushed
the
topic/non-int-ids
branch
from
1a713a9
to
7ebd1d5
Compare
|
locally merged with minor changes: removed sinceState validation from ix_get, which we already killed off; will soon add a commit to not explain under-hood validation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are a number of arguments that are strings in JMAP and integers in
the database, such as id fields, and sinceState.
These weren't being validated and would throw db exceptions if non-integer
data was passed in.