ignore ProcessRunner test fail on windows cmake

pocoproject · May 20, 2024 · 83162c6 · 83162c6
1 parent 396d3fd
commit 83162c6
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 7 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -555,7 +555,8 @@ jobs:
         class CppUnit::TestCaller<class ICMPClientTest>.testBigPing,
         class CppUnit::TestCaller<class ICMPSocketTest>.testMTU,
         class CppUnit::TestCaller<class HTTPSClientSessionTest>.testProxy,
-        class CppUnit::TestCaller<class HTTPSStreamFactoryTest>.testProxy
+        class CppUnit::TestCaller<class HTTPSStreamFactoryTest>.testProxy,
+        class CppUnit::TestCaller<class ProcessRunnerTest>.testProcessRunner # windows cmake CI has messed up env path
     steps:
       - uses: actions/checkout@v4
       - run: cmake -S. -Bcmake-build -DENABLE_NETSSL_WIN=ON -DENABLE_NETSSL=OFF -DENABLE_CRYPTO=OFF -DENABLE_JWT=OFF -DENABLE_DATA=ON -DENABLE_DATA_ODBC=ON -DENABLE_DATA_MYSQL=OFF -DENABLE_DATA_POSTGRESQL=OFF -DENABLE_TESTS=ON

diff --git a/Foundation/src/File.cpp b/Foundation/src/File.cpp
@@ -132,12 +132,7 @@ std::string File::absolutePath() const
 					}
 					catch (const Poco::PathSyntaxException&)
 					{
-						// this try/catch is only here to prevent windows cmake CI from failing
-						// (apparently bad windows path settings in the CI environment):
-						//
-						// class CppUnit::TestCaller<class ProcessRunnerTest>.testProcessRunner
-						// "class Poco::PathSyntaxException:
-						// Bad path syntax: D:/a/poco/poco/cmake-build/bin:C:\Program Files\PowerShell\7\TestApp"
+						// shield against bad PATH environment entries
 					}
 				}
 			}