Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for MYSQL_TYPE_NEWDECIMAL to Poco::Data::MySQL #154

Closed
simon-graham opened this issue Apr 16, 2013 · 1 comment
Closed

Add support for MYSQL_TYPE_NEWDECIMAL to Poco::Data::MySQL #154

simon-graham opened this issue Apr 16, 2013 · 1 comment
Assignees
Milestone

Comments

@simon-graham
Copy link
Contributor

Data::MySQL does not fully support decimal types. I believe the only change necessary in the 1.5.x code is to add MYSQL_TYPE_NEWDECIMAL to the fieldType() function in /Data/MySQL/src/ResultMetadata.cpp.

We can see that MYSQL_TYPE_NEWDECIMAL is already present in the fieldSize() function, but missing from fieldType().

I believe that the correct meta type to map decimal to is FDT_STRING. All of the MySQL Server test cases seem to use strings for mapping decimals. For example, see test_decimal_bug here

@ghost ghost assigned aleks-f Apr 16, 2013
@aleks-f
Copy link
Member

aleks-f commented Apr 16, 2013

Can't promise this for 1.5.2; to speed it up, it would be good if you could add the code, write and run some tests and send pull request.

@aleks-f aleks-f added this to the Release 1.5.3 milestone May 11, 2014
aleks-f added a commit that referenced this issue May 12, 2014
GH #154 Add support for MYSQL_TYPE_NEWDECIMAL to Poco::Data::MySQL
@aleks-f aleks-f closed this as completed May 12, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants