Implementation of Path::self() #4319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matejk
force-pushed
the
2282-path-self
branch
from
74232e3
to
60d50e8
Compare
aleks-f
requested changes
Dec 4, 2023
|
@aleks-f , it is very unlikely that the functions to get current program name would fail, however: shall an exception be thrown in that case? |
aleks-f
requested changes
Dec 4, 2023
|
|
||
| assertTrue(!self.empty()); | ||
| Path p(self); | ||
|
|
||
| assertTrue(p.isAbsolute()); | ||
| assertTrue(p.isFile()); | ||
| assertTrue(self.find("testrunner") != std::string::npos); | ||
|
|
||
| #else | ||
| std::cout "Path::self() not implemented for this platform." |
yes, throw something appropriate |
Closed
…on-implemented platform.
matejk
force-pushed
the
2282-path-self
branch
from
2e93c1a
to
f6bc0ab
Compare
aleks-f
approved these changes
Dec 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains content of PR #3758 by @JackyWoo with minor additional changes.
Resolves #2282.