Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mapping Core Environment Variables #6

Open
digitalsadhu opened this issue Mar 1, 2023 · 0 comments
Open

Mapping Core Environment Variables #6

digitalsadhu opened this issue Mar 1, 2023 · 0 comments

Comments

@digitalsadhu
Copy link
Member

Currently, we expect that the variables DOMAIN and ENV are set and all other config values are potentially affected by what these are set to. Loading of config overrides is done using these 2 values like so:

/config/domains/{DOMAIN}/{ENV}.config.json

At Finn, we use the environment FIAAS_ENVIRONMENT which roughly equates to the expected ENV. There's currently no clear place that one might map FIAAS_ENVIRONMENT to ENV. Ideally, infrastructure would set the ENV but in cases where that's not practical, how should we suggest this be handled?

  • set ENV to = FIAAS_ENVIRONMENT in a bash script
  • set it in code somewhere?
  • make it possible to configure the name of the ENV and DOMAIN env var names?
  • something else?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant