Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update test for has_introspection_type? to reflect that the function is now called safe? #3

Open
alex0112 opened this issue Jan 11, 2023 · 0 comments
Open

Update test for has_introspection_type? to reflect that the function is now called safe? #3

alex0112 opened this issue Jan 11, 2023 · 0 comments

Comments

@alex0112
Copy link
Contributor

https://github.com/podium/vigil/blob/main/test/vigil/query_test.exs#L25

The function test here needs to be updated so that the phrasing of the test clause reflects the actual behavior and name of the function. I believe this is left over from a refactor and we just forgot to update the test.

Currently I believe the function is testing the correct behavior, it's just named incorrectly. So not urgent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@alex0112