Properly set post type param to fix issues with Polylang and possibly others. #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Polylang auto enables translation if the post type is `any`, this causes edge case issues for non-translatable post types.
|
looks good for me! |
quasel
approved these changes
Oct 16, 2020
sc0ttkclark
approved these changes
Dec 30, 2020
|
@sc0ttkclark Why was this closed? I just encountered the same issue again, I thought this was merged haha @quasel Maybe revive this one? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting the post type to
anycan cause edge case issues with other plugins and WP core.For non-translatable post types this will create compatibility issues with Polyland since adding
anywill trigger Polylang to add the language queries, even though the ID's might not be translatable.Other than that, setting
anyalso affects WP default query to only include public posts. I can imagine edge cases where this might cause issues.