Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly set post type param to fix issues with Polylang and possibly others. #117

Merged
merged 3 commits into from
Aug 17, 2022

Conversation

JoryHogeveen
Copy link
Member

Second try PR :) Prev: #109

Setting the post type to any can cause edge case issues with other plugins and WP core.

For non-translatable post types this will create compatibility issues with Polyland since adding any will trigger Polylang to add the language queries, even though the ID's might not be translatable.

Other than that, setting any also affects WP default query to only include public posts. I can imagine edge cases where this might cause issues.

Added enhancement to the above for relationship fields.

JoryHogeveen and others added 3 commits October 15, 2020 15:58
Polylang auto enables translation if the post type is `any`, this causes edge case issues for non-translatable post types.
Enhances Polylang compatibility
@quasel
Copy link
Member

quasel commented May 21, 2022

looks god so far - but I'm a bit out of the loop ;) - hope to help out more soon again!

@sc0ttkclark any objections?

@quasel quasel added the bug label May 21, 2022
@quasel
Copy link
Member

quasel commented May 21, 2022

oh and if I remember correctly we should create a branch for the next release that then get's merged into main…

@JoryHogeveen
Copy link
Member Author

@quasel No problem, maybe you can create a branche and name it as you like, perhaps the version number or just dev?

@JoryHogeveen
Copy link
Member Author

@quasel @sc0ttkclark
Let me know if there is anything else you need from me. It's been a while since the latest update from this plugin so I think this would be a good addition for compatibility.

@quasel quasel merged commit c031d0a into pods-framework:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants