-
-
Notifications
You must be signed in to change notification settings - Fork 264
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
currency depends on 2 arrays for each currency (can be reduced) #1915
Comments
main declaration in public static $currencies and extra in |
If you want to have a PR for this, I'd support it, otherwise I'll add this to the list for 3.0 stuff for me. I'd like to see this: public static $currencies = array(
'usd' => array(
'label' => 'USD',
'sign' => '$'
),
'cad' => array(
'label' => 'CAD',
'sign' => '$'
),
'euro' => array(
'label' => 'Euro',
'sign' => '€'
),
'gbp' => array(
'label' => 'GBP',
'sign' => '£'
)
); The best solution would still allow for the other filters to continue to function as they were as the backup, but utilize a new filter in |
im a classy noob ... so good luck with that yourself :-) |
No problem, I'll get to it at some point. |
could also be 1 array set
making it easier to add currencies in the future / patches
The text was updated successfully, but these errors were encountered: