Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

currency depends on 2 arrays for each currency (can be reduced) #1915

Closed
Ramoonus opened this issue Dec 21, 2013 · 4 comments
Closed

currency depends on 2 arrays for each currency (can be reduced) #1915

Ramoonus opened this issue Dec 21, 2013 · 4 comments
Assignees
Labels
Type: Enhancement Enhancements to features that already exist, but are not major additions
Milestone

Comments

@Ramoonus
Copy link
Contributor

could also be 1 array set
making it easier to add currencies in the future / patches

@Ramoonus
Copy link
Contributor Author

main declaration in public static $currencies

and extra in
self::$type . '_format_sign' => array( 'label' => __( 'Currency Sign', 'pods' ),

@ghost ghost assigned sc0ttkclark Dec 22, 2013
@sc0ttkclark
Copy link
Member

If you want to have a PR for this, I'd support it, otherwise I'll add this to the list for 3.0 stuff for me.

I'd like to see this:

    public static $currencies = array(
        'usd' => array(
            'label' => 'USD',
            'sign' => '$'
        ),
        'cad' => array(
            'label' => 'CAD',
            'sign' => '$'
        ),
        'euro' => array(
            'label' => 'Euro',
            'sign' => '€'
        ),
        'gbp' => array(
            'label' => 'GBP',
            'sign' => '£'
        )
    );

The best solution would still allow for the other filters to continue to function as they were as the backup, but utilize a new filter in __construct. So something that runs the other filters and translate them into the new array would be preferred. Also, the 'data' array in options will need building out based on the self::$currencies array too, put the 'label' in the parenthesis and have sign appear before.

@Ramoonus
Copy link
Contributor Author

im a classy noob ... so good luck with that yourself :-)

@sc0ttkclark
Copy link
Member

No problem, I'll get to it at some point.

@sc0ttkclark sc0ttkclark removed their assignment May 26, 2014
@sc0ttkclark sc0ttkclark modified the milestones: Pods 3.1, Pods 3.0 Jun 4, 2014
@sc0ttkclark sc0ttkclark modified the milestones: Pods 3.1, Pods Future Release Dec 21, 2015
@Ramoonus Ramoonus mentioned this issue Jan 17, 2017
7 tasks
@JoryHogeveen JoryHogeveen self-assigned this Jan 19, 2017
@sc0ttkclark sc0ttkclark modified the milestones: Pods 2.6.8, Pods Future Release Jan 19, 2017
@sc0ttkclark sc0ttkclark removed Status: Help Wanted We have not prioritized this yet, but you can help make it happen to speed it up Keyword: Puntable labels Jan 19, 2017
@jimtrue jimtrue added the Status: In Progress Issue or PR is currently in progress but not yet done label Jan 19, 2017
sc0ttkclark added a commit that referenced this issue Jan 19, 2017
@sc0ttkclark sc0ttkclark removed the Status: In Progress Issue or PR is currently in progress but not yet done label Jan 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Enhancement Enhancements to features that already exist, but are not major additions
Projects
None yet
Development

No branches or pull requests

4 participants