Fix PHP7 Compatibility issues #3830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimtrue
added
the
Status: In Progress
|
@sc0ttkclark Please check deprecated.php.
What would you like to do with this function? Is it even used anywhere? |
JoryHogeveen
commented
Oct 27, 2016
|
|
||
| $column_data = array(); | ||
|
|
||
| while ( $column_row = mysql_fetch_assoc( $describe_data ) ) { | ||
| foreach ( $describe_data as $column_row ) { | ||
| $column_data[] = $column_row; | ||
| } | ||
|
|
There was a problem hiding this comment.
This function could be simplified by just using $describe_data instead of creating a new var ($column_data) since the contents will be the same when using $wpdb.
|
If there's a way to refactor pod_query to act like it does now but have it work, great. Otherwise I'm okay with throwing doing it wrong notices and map the query directly to pods_query() because we can't do anything further at that point. |
sc0ttkclark
removed
the
Status: In Progress
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #3828