Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Manage Fields: avoid stripping any intentionally inserted literal HTML #5256

Merged
merged 1 commit into from
Feb 5, 2019
Merged

Manage Fields: avoid stripping any intentionally inserted literal HTML #5256

merged 1 commit into from
Feb 5, 2019

Conversation

pglewis
Copy link
Contributor

@pglewis pglewis commented Dec 21, 2018

Fixes #5246

@pglewis
Make sure $pick_object_name is pre-sanitized where set and remove t…
19ca0e3 
…he blanket `esc_html` on output to avoid stripping any intentionally inserted literal HTML
@pglewis pglewis added Type: Bug Component: UI Issues related to user experience and interfaces Status: PR > QA pending QA needs to be done labels Dec 21, 2018
@pglewis pglewis added this to the 2.7.13 milestone Dec 21, 2018
@pglewis pglewis self-assigned this Dec 21, 2018
@pglewis pglewis mentioned this pull request Dec 21, 2018
Closed
@pglewis pglewis added the Status: PR > Pending Code Review PR is pending code review by core developers label Dec 21, 2018
@sc0ttkclark sc0ttkclark added Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) and removed Status: PR > Pending Code Review PR is pending code review by core developers labels Jan 22, 2019
@pglewis pglewis merged commit da26dfa into 2.x Feb 5, 2019
@pglewis pglewis deleted the feature/5246-literal-html-being-escaped branch February 5, 2019 20:39
@pglewis pglewis mentioned this pull request Feb 18, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sc0ttkclark sc0ttkclark sc0ttkclark approved these changes

@JoryHogeveen JoryHogeveen JoryHogeveen approved these changes

Assignees

@pglewis pglewis

Labels
Component: UI Issues related to user experience and interfaces Status: PR > QA pending QA needs to be done Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) Type: Bug
Projects
None yet
Milestone
Pods 2.7.13
Development

Successfully merging this pull request may close these issues.
3 participants
@pglewis @sc0ttkclark @JoryHogeveen