Fix meta sanitizing (again) #5910
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit sets the fix in #5665 to only occur with WP object fields, not Pod options and other data.
JoryHogeveen
added
Type: Bug
Priority: Blocker
sc0ttkclark
added
Status: PR > Reviewed and Ready
sc0ttkclark
previously approved these changes
Jan 6, 2021
Tests for proper sanitztion
JoryHogeveen
added
Status: Unit Tested
sc0ttkclark
approved these changes
Mar 1, 2021
JoryHogeveen
added
Status: PR > QA pass
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5909 (Confirmed: 1x)
Description
Fixes new bug introduced with #5665
How Has This Been Tested?
Tested with unit tests and #5909 fix.
Needs more unit tests.
Screenshots or Screencast
Types of changes
This PR sets the fix in #5665 to only occur with WP object fields, not Pod options and other data.
Changelog text for these changes
PR Checklist