Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Auto Template cache to be refreshed on save #6172

Merged
merged 1 commit into from
Oct 17, 2021

Conversation

jamesgol
Copy link
Contributor

Using the 'update_option' action and checking for a specific option to be set has too many assumptions and wasn't working on my test. This switches to the 'pods_cache_flushed' action.

Additionally, if the reset attempt did ever get made the actual transient name was wrong. The additional transients that get cleared probably aren't necessary anymore but do not hurt anything.

Description

I was talking to a user on slack about auto templates and I couldn't get it to work until I manually cleared the transients. I'm not sure if this ever worked properly.

Using the 'update_option' action and checking for a specific option to be set has too many assumptions and wasn't working on my test.  This switches to the 'pods_cache_flushed' action.

Additionally, if the reset attempt did ever get made the actual transient name was wrong.  The additional transients that get cleared probably aren't necessary anymore but do not hurt anything.
@sc0ttkclark sc0ttkclark added Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) Status: PR > QA pass QA passed labels Oct 17, 2021
@sc0ttkclark sc0ttkclark merged commit 18021a7 into pods-framework:release/2.8 Oct 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: PR > QA pass QA passed Status: PR > Reviewed and Ready PR has been code reviewed by core developers and is ready for merge (if it passes QA) Type: Bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants