Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove from field names ending "Key" and "Keys". Consistent singular and plural (for arrays) field names. #1

Open
SnosMe opened this issue Jun 27, 2021 · 1 comment

Comments

@SnosMe
Copy link
Collaborator

SnosMe commented Jun 27, 2021

Preferably only when there is changes to be made to the table, especially when it comes to popular ones, so we don't annoy people with renames 😄

@evanwarner
Copy link
Contributor

It's probably smart to establish consistent naming rules across the board. (I noticed you tweaked my key name for Ruthless item costs.) Perhaps we can come up with a good set of guidelines for naming and add it to the README.

This would have to be rolled out in a major version update as it would be a breaking change for anyone using the current schema.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants