Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::io::Error::other is not yet stablized. #732

Closed
Richardn2002 opened this issue Jan 17, 2024 · 1 comment · Fixed by #735
Closed

std::io::Error::other is not yet stablized. #732

Richardn2002 opened this issue Jan 17, 2024 · 1 comment · Fixed by #735
Labels
bug Something isn't working

Comments

@Richardn2002
Copy link

Expected Behavior

poem=2.0.0 builds on latest stable Rust.

Actual Behavior

A single use of #std::io::Error::other at

.map_err(std::io::Error::other)

prevents the build on stable. See rust-lang/rust#91946

Steps to Reproduce the Problem

Build with latest stable Rust (1.75.0)

Potential fix

use

.map_err(|e| Error::new(std::io::ErrorKind::Other, e))

instead.

P.S. As a startup company, we are building our complete backend on top of Poem. We are very grateful of and impressed by the niceties and power of the Poem framework, so thanks Sunli and all the contributors. If we managed to launch successfully, we are happy to be listed as a showcase of the Poem framework, but that is a thing for the future :P .

@Richardn2002 Richardn2002 added the bug Something isn't working label Jan 17, 2024
@Richardn2002
Copy link
Author

Oh I am sorry, the feature is already stabilized in Rust 1.74.0. It is a problem of our toolchains not being updated correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant