Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Semantic Release Broken #155

Closed
lautarodragan opened this issue Sep 21, 2018 · 4 comments · Fixed by #156
Closed

Semantic Release Broken #155

lautarodragan opened this issue Sep 21, 2018 · 4 comments · Fixed by #156
Assignees

Comments

@lautarodragan
Copy link
Member

@warren Vosper @walter @wesley I think semantic-release is broken for Po.et JS

16.88s$ [[ $TRAVIS_BRANCH = "master" && $TRAVIS_PULL_REQUEST_BRANCH = "" ]] && (npm install -g travis-deploy-once && travis-deploy-once "npm run semantic-release")
/home/travis/.nvm/versions/node/v10.10.0/bin/travis-deploy-once -> /home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/bin/travis-deploy-once.js
+ travis-deploy-once@5.0.8
added 259 packages from 105 contributors in 16.114s
/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/files/plugins.js:152
    throw e;
    ^
Error: Cannot find module '@babel/preset-env' from '/home/travis/build/poetapp/poet-js'
    at Function.module.exports [as sync] (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/resolve/lib/sync.js:43:15)
    at resolveStandardizedName (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/files/plugins.js:101:31)
    at resolvePreset (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/files/plugins.js:58:10)
    at loadPreset (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/files/plugins.js:77:20)
    at createDescriptor (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/config-descriptors.js:154:9)
    at items.map (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/config-descriptors.js:109:50)
    at Array.map (<anonymous>)
    at createDescriptors (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/config-descriptors.js:109:29)
    at createPresetDescriptors (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/config-descriptors.js:101:10)
    at passPerPreset (/home/travis/.nvm/versions/node/v10.10.0/lib/node_modules/travis-deploy-once/node_modules/@babel/core/lib/config/config-descriptors.js:58:96)

sadly, Travis doesn't report a failure for semantic-release failures

Looks like the culprit was this commit: b2ed8df

update dependency semantic-release to v15.9.16

@lautarodragan lautarodragan added this to the Mainnet-beta milestone Sep 21, 2018
@lautarodragan
Copy link
Member Author

@geoffturk this is pretty critical. it prevents us from releasing new versions of poet-js

@lautarodragan
Copy link
Member Author

lautarodragan commented Sep 21, 2018

Could be related to https://www.npmjs.com/package/babel-preset-env being deprecated/archived in favor of https://www.npmjs.com/package/@babel/preset-env

@lautarodragan
Copy link
Member Author

Diff of the changes introduced in semantic-release 15.9.16: semantic-release/semantic-release@v15.9.15...v15.9.16

Looks like dependency upgrades only. Not sure what's going on.

@poet-ci
Copy link

poet-ci commented Sep 21, 2018

🎉 This issue has been resolved in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants