Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Contact Emails To Default Parsed Output #9

Closed
uBadRequest opened this issue Sep 13, 2020 · 1 comment
Closed

Add Contact Emails To Default Parsed Output #9

uBadRequest opened this issue Sep 13, 2020 · 1 comment

Comments

@uBadRequest
Copy link

uBadRequest commented Sep 13, 2020

I noticed that contact emails aren't being parsed by default and seems to be commented out in the code, any reasons why?

Should I fork and add email or was there a problem?

@pogzyb
Copy link
Owner

pogzyb commented Sep 13, 2020

No, you should be able to uncomment or add parsers for emails without a problem. This package started out as a small piece of a larger security project of mine where I really only needed to reliably parse dates and address information, so I forewent adding parsers for contact fields at the time.

I'll admit I'm probably more focused on getting wider TLD coverage rather than fully supporting the contact stuff right now; so yes, please go ahead and fork for your own needs.

Good luck!

@pogzyb pogzyb closed this as completed Jan 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants