Podcast RSS final touches #317

mbrandonw · 2018-10-04T01:25:13Z

This should be everything we need to launch the feature, other than some data entry.

mbrandonw · 2018-10-04T01:25:27Z

Sources/PointFree/Account/Account.swift

@@ -375,7 +375,7 @@ to consume our videos: an RSS feed that can be used with podcast apps!
                  ],
                  [
                    text(
-                      String(url(to: .account(.rss(userId: user.id, rssSalt: user.rssSalt))).prefix(45))
+                      String(url(to: .account(.rss(userId: user.id, rssSalt: user.rssSalt))).prefix(40))


trimming this a bit cause the screenshot test showed it didn't fit on smaller devices.

mbrandonw · 2018-10-04T01:26:10Z

Sources/PointFree/Account/PrivateRss.swift

@@ -269,6 +269,8 @@ please contact support@pointfree.co.

 func clearHeadBody<I>(_ conn: Conn<I, Data>) -> IO<Conn<I, Data>> {
  return IO {
+    // TODO: this doesn't actually work. The `conn.request.httpBody` has all the
+    // data, and that's what needs to be cleared.


when I tried writing a test for the HEAD request I realized this doesnt do what I expected. we need to be able to clear the request's body, which means this helper needs to live in HttpPipeline.

mbrandonw · 2018-10-04T01:26:49Z

Sources/PointFree/AtomFeed.swift

@@ -8,7 +8,7 @@ let atomFeedResponse =
  writeStatus(.ok)
    >=> respond(pointFreeFeed, contentType: .application(.atom))

-let episodesRssMiddleware: Middleware<StatusLineOpen, ResponseEnded, SubscriberState, Data> =
+let episodesRssMiddleware: Middleware<StatusLineOpen, ResponseEnded, Prelude.Unit, Data> =


I dont know why this middleware took SubscriberState since it's an unauthenticated endpoint. luckily I wasn't actually using it anywhere, so I was able to remove it easily from a few spots.

mbrandonw · 2018-10-04T01:27:11Z

Sources/PointFree/AtomFeed.swift

-      ? """
-Subscriber-Only: Today's episode is available only to subscribers. If you are a Point-Free subscriber you \
-can access your private podcast feed by visiting \(url(to: .account(.index))).
+    switch episode.permission {


here's where I provide 3 different types of copy for the episode description / show notes based on the episode's permission.

mbrandonw · 2018-10-04T01:27:39Z

Sources/PointFree/AtomFeed.swift

@@ -153,7 +167,7 @@ that day!
    description: description(episode: episode),
    dublinCore: .init(creators: ["Brandon Williams", "Stephen Celis"]),
    enclosure: enclosure(episode: episode),
-    guid: url(to: .episode(.left(episode.slug))),
+    guid: String(describing: episode.freeSince ?? episode.publishedAt),


using the episodes free date / published date as the GUID allows us to create a new entry for episodes that were subscriber only and then switched to free.

Is String(describing:) subject to weird local/locale formatting? Should we use a DateFormatter to be safe for testing?

oh im not sure. I could also just use the underlying time interval. how's that sound?

Oh yeah that sounds perf!

coo done 5fd134f

mbrandonw · 2018-10-04T01:27:55Z

Sources/PointFree/AtomFeed.swift

+      |> respond(
+        body: view.rendered(
+          with: conn.data,
+          config: Current.envVars.appEnv == .testing ? .pretty : .compact


pretty printing for our atom feed tests

mbrandonw · 2018-10-04T01:28:15Z

Sources/PointFree/EnvVars.swift

    case production
+    case staging
+    case testing


added a testing case so that we could pretty print only for tests. we could prob also get rid of staging.

mbrandonw · 2018-10-04T01:28:29Z

Sources/PointFree/Episode/Episode.swift

    exercises: [Exercise],
    fullVideo: Video? = nil,
+    id: Id,


somehow this got out of order, had to fix all the episodes too

mbrandonw · 2018-10-04T01:29:11Z

Sources/PointFree/FeatureFlags.swift

+        $0.isEnabled
+          || ($0.isAdminEnabled && user?.isAdmin == .some(true))
+      }
+      ?? false


ok, the whole [Feature].hasAccess(to:) API is so whack. I dont know what I was thinking when I wrote it. here I just did a minimal amount of work to make it sensible, but we should revamp it sometime soon.

mbrandonw · 2018-10-04T01:29:24Z

Sources/PointFree/PageLayout.swift

@@ -121,17 +121,31 @@ func respond<A, B>(
        >=> respond(
          body: pageLayout.rendered(
            with: newLayoutData,
-            config: Current.envVars.appEnv == .production ? .compact : .pretty
+            config: Current.envVars.appEnv == .testing ? .pretty : .compact


let's only pretty print in testing, not development.

mbrandonw · 2018-10-04T01:29:59Z

Sources/PointFree/PageLayout.swift

+    let episodeAtomFeed = Html.link([
+      hasPodcastRssFeature
+        ? href(url(to: .feed(.episodes)))
+        : href(url(to: .feed(.atom))),


feature flagging the feeds in the meta tags.

mbrandonw · 2018-10-04T01:30:19Z

Sources/PointFree/PublicEpisodes/0000-Introduction.swift

@@ -2,12 +2,12 @@ import Foundation

 let introduction = Episode(
  blurb: """
-Point-Free is here, bringing you videos covering functional programming concepts using the Swift language.
+Point-Free is here, bringing you videos covering functional programming concepts using the Swift language. \


best to not have newlines for episode blurbs cause some readers will render them

mbrandonw · 2018-10-04T01:31:25Z

Tests/PointFreeTests/AtomFeedTests.swift

+    assertSnapshot(matching: result.perform())
+  }
+
+  func testEpisodeFeed_WithRecentlyFreeEpisode() {


this test shows that an older episode that was recently made free gets bumped to the top

mbrandonw · 2018-10-04T01:32:32Z

...FreeTests/__Snapshots__/PrivateRssTests/testFeed_Authenticated_InActiveSubscriber.1.Conn.txt

+      en-US
+    </language>
+    <description>
+      ‼️ The URL for this feed has been turned off by Point-Free. You can retrieve your most up-to-date private podcast URL by visiting your account page at http://localhost:8080/account. If you think this is an error, please contact support@pointfree.co.


this is what the feed looks like for non-subscribers / in-active subscribers / people with bad feed urls.

stephencelis

All looks good! Was scared by the diff stats before realizing it was a snap :)

* wip * wip * wip * alpha * wip * some more tests * wip * wip * remove newlines from blurbs * add another test * update snaps * better explanations * clean up * clean up * time interval guid

* wip * wip * wip * alpha * wip * some more tests * wip * wip * remove newlines from blurbs * add another test * update snaps * better explanations * clean up * clean up * time interval guid Former-commit-id: 33fd8a3

mbrandonw added 14 commits October 2, 2018 21:35

wip

afb641c

wip

db0ce28

Merge remote-tracking branch 'origin/master' into more-rss

9da1e66

wip

e78f8fc

alpha

1f78113

wip

93a4799

some more tests

7e8c82c

wip

60bb768

wip

11ca252

remove newlines from blurbs

98318e5

add another test

21f1cc8

update snaps

c5681c5

better explanations

ecf56ee

clean up

ef2762d

mbrandonw requested a review from stephencelis October 4, 2018 01:25

mbrandonw commented Oct 4, 2018

View reviewed changes

clean up

4805596

mbrandonw commented Oct 4, 2018

View reviewed changes

stephencelis approved these changes Oct 4, 2018

View reviewed changes

time interval guid

5fd134f

mbrandonw merged commit 5c33671 into master Oct 4, 2018

mbrandonw deleted the more-rss branch October 4, 2018 02:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Podcast RSS final touches #317

Podcast RSS final touches #317

mbrandonw commented Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

stephencelis Oct 4, 2018

mbrandonw Oct 4, 2018

stephencelis Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018

mbrandonw Oct 4, 2018 •

edited

Loading

stephencelis left a comment

Podcast RSS final touches #317

Podcast RSS final touches #317

Conversation

mbrandonw commented Oct 4, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mbrandonw Oct 4, 2018 • edited Loading

Choose a reason for hiding this comment

stephencelis left a comment

Choose a reason for hiding this comment

mbrandonw Oct 4, 2018 •

edited

Loading