Platform cleanup (fixes DMG-on-CGB) #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced May 29, 2020
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Submitting the "Mickey fix" on gifvex's behalf. This fixes two issues (1 major, 1 minor) seen in Mickey's Dangerous Chase testing, while attempting to console-verify a resynced TAS:
Major fix: Use CGB LCD timings for DMG-only games being played on CGB. (Previous GSR behavior switched the whole LCD to DMG for these games; this didn't matter for Pokémon Red/Blue, but it does matter for DMG-only games like Mickey that use more LCD functionality.)
Minor fix: Fix writes to $FF22 (NR43) to reset
counter_. This was uncovered since the sound effect for taking damage in Mickey appeared to be skipped in all versions of Gambatte. Debugging showed the noise channel playing a single sample of the effect, then not producing sound until reachingcounter_~0.5 seconds later (after an $E7 write, implying ~2 Hz sound). Resettingcounter_on $FF22 writes resulted in the proper behavior of playing the full sound effect.All hwtests still pass after these changes, and no other regressions in behavior have been observed in testing (or in re-encodes of previous movies).