Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XRayInstrument should map HTTP Span attributes to XRay segment HTTP #22

Open
pokryfka opened this issue Jul 24, 2020 · 1 comment
Open
Labels
enhancement New feature or request

Comments

@pokryfka
Copy link
Owner

pokryfka commented Jul 24, 2020

XRayInstrument should try to map HTTP Span attributes to XRay Segment HTTP request metadata

see comparison of XRay segment against OT Span

@pokryfka
Copy link
Owner Author

Currently all OT attributes are logged as annotations or metadata, example:

{
  "service" : {
    "version" : "aws-xray-sdk-swift"
  },
  "end_time" : 1595597689.3613839,
  "id" : "d0fae7e50034a757",
  "annotations" : {
    "http.method" : "GET",
    "http.url" : "https:\/\/aws.amazon.com",
    "http.response_content_length" : 212445,
    "http.status_code" : "200"
  },
  "start_time" : 1595597687.7261341,
  "trace_id" : "1-5759e988-bd862e3fe1be46a994272793",
  "name" : "HTTP https:\/\/aws.amazon.com"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant