-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Load Testing] Permissionless Demand Implementation Umbrella Ticket #758
Comments
Olshansk
changed the title
[Load Testing] Permissionless Demand Implementation Umbrella Ticket
[WIP][Load Testing] Permissionless Demand Implementation Umbrella Ticket
Aug 23, 2024
Olshansk
changed the title
[WIP][Load Testing] Permissionless Demand Implementation Umbrella Ticket
[Load Testing] Permissionless Demand Implementation Umbrella Ticket
Aug 24, 2024
6 tasks
This was referenced Aug 27, 2024
15 tasks
red-0ne
added a commit
that referenced
this issue
Sep 6, 2024
## Summary This PR adds `ProofSubmissionFee` governance param as a `Coin` type. It is based on PR #778 ## Issue Proof messages take up a lot of block space. We need to deter submitting unnecessary ones by making their submission payable by a governance adjusted parameter. The current PR is only about adding the governance param. The feature itself will be submitted as a follow-up PR. - #758 ## Type of change Select one or more: - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable
red-0ne
added a commit
that referenced
this issue
Sep 6, 2024
## Summary This PR implements payable proof submission given the proof submission governance param. This is a follow-up feature PR to #779 which adds the proof submission governance param. ## Issue Proof messages take up significant block space. We need to deter submitting non-required ones by making proof submission payable by a governance adjusted parameter. - #758 ## Type of change Select one or more: - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable
red-0ne
added a commit
that referenced
this issue
Sep 6, 2024
## Summary This PR introduces the proof params to the `RelayMiner` so it does not submit proofs when not required. The E2E and `SessionManager` tests have been updated to account for proof requirement. ## Issue The `RelayMiner`'s `SessionManager` was systematically submitting proofs on-chain whether they were required or not. This led to a state chain bloat since proofs are what takes most for the block space. Given the permissionless nature of the protocol, this causing scalability issues. - #758 ## Type of change Select one or more: - [x] New feature, functionality or library - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Testing - [ ] **Documentation**: `make docusaurus_start`; only needed if you make doc changes - [x] **Unit Tests**: `make go_develop_and_test` - [x] **LocalNet E2E Tests**: `make test_e2e` - [ ] **DevNet E2E Tests**: Add the `devnet-test-e2e` label to the PR. ## Sanity Checklist - [x] I have tested my changes using the available tooling - [x] I have commented my code - [x] I have performed a self-review of my own code; both comments & source code - [ ] I create and reference any new tickets, if applicable - [x] I have left TODOs throughout the codebase, if applicable --------- Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
This was referenced Sep 9, 2024
Open
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Objective
Ensure there will not be any scalability issues in Shannon.
This is done by:
Origin Document
Goals
Deliverables
Ensure the
ProofParams
is used and reflected in theRelayMiner
. It doesn't seem these are being used:Increase the tx fee of the
SubmitProof
msg so it's larger than a simple sendAddService
, it can be used to learn and other understand properitery ways of doing this. Note that the only reason we didn't look into using cosmos tx fees in the past, is because we didn't have time.AddService
@Olshansk to build documentation for this. Specifically:
x/tokenomics/keeper/settle_pending_claims.go
Implement the Relay Mining & Probabilistic Proof multiplier + closed loop systems
Implement the supplier stake <> proof requirement threshold closed loop system
Implement slashing for missing proofs [Supplier] Initial slashing implementation #795
Look for TODOs in the code that call out
SparseCompactClosestProof
Exploratory: Review all the probabilistic proof parameters and make sure they adjust dynamically based on the volume, similar to relay mining.
Non-goals / Non-deliverables
Creator: @Olshansk
Co-Owners: @okdas @red-0ne
The text was updated successfully, but these errors were encountered: