Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[RelayMiner] LeanClient #567

Merged
merged 66 commits into from
Jun 15, 2024
Merged

[RelayMiner] LeanClient #567

merged 66 commits into from
Jun 15, 2024

Conversation

okdas
Copy link
Member

@okdas okdas commented May 30, 2024 •
edited
Loading

Summary

Adds an ability to run many suppliers on one relayminer

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

Documentation changes (only if making doc changes)

  • make docusaurus_start; only needed if you make doc changes

Local Testing (only if making code changes)

  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • See quickstart guide for instructions

PR Testing (only if making code changes)

  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.
    • THIS IS VERY EXPENSIVE, so only do it after all the reviews are complete.
    • Optionally run make trigger_ci if you want to re-trigger tests without any code changes
    • If tests fail, try re-running failed tests only using the GitHub UI as shown here

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added the relayminer Changes related to the Relayminer label May 30, 2024
@okdas okdas added this to the Shannon Alpha TestNet Launch milestone May 30, 2024
@okdas okdas self-assigned this May 30, 2024
okdas
okdas commented May 30, 2024
View reviewed changes
pkg/relayer/cmd/cmd.go Outdated Show resolved Hide resolved
okdas
okdas commented Jun 1, 2024
View reviewed changes
pkg/relayer/session/session.go Outdated Show resolved Hide resolved
okdas
okdas commented Jun 4, 2024
View reviewed changes
pkg/client/supplier/client.go Outdated Show resolved Hide resolved
okdas and others added 16 commits June 12, 2024 15:24
@okdas @Olshansk
Update pkg/client/interface.go
48f61c2 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas @Olshansk
Update go.mod
16909e5 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas @Olshansk
Update pkg/relayer/config/supplier_hydrator.go
855399f 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas @Olshansk
Update testutil/testproxy/relayerproxy.go
1648312 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas @Olshansk
Update proto/poktroll/service/relay.proto
2882e60 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas @Olshansk
Update pkg/relayer/proxy/proxy.go
3c8a286 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas @Olshansk
Update pkg/relayer/proxy/proxy.go
28a5379 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas @Olshansk
Update go.mod
25849e0 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas
--wip-- [skip ci]
568b1e0
@okdas @Olshansk
Update docusaurus/docs/operate/configs/relayminer_config.md
f1a7ee0 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas
more requested changes
899abbd
@okdas
more requested changes
ffde275
@okdas
Merge branch 'main' into issue/528-lean-client
fcb59fe
@okdas
more resolve issues after merge from main
bd83c1e
@okdas
more adjustments after moving things around
bb366df
@okdas
fix keeper tests
939e002
@okdas okdas requested review from Olshansk and red-0ne June 14, 2024 00:44
red-0ne
red-0ne approved these changes Jun 14, 2024
View reviewed changes
Copy link
Contributor

@red-0ne red-0ne left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. 🚀

@okdas
Copy link
Member Author

okdas commented Jun 14, 2024

Seems like the only e2e test that fails is the same flaky TestFeatures/Session_Namespace/Supplier_completes_claim/proof_lifecycle_for_a_valid_session.

Olshansk
Olshansk approved these changes Jun 14, 2024
View reviewed changes
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of NITs but LGTM. Please merge with main

x/proof/keeper/msg_server_submit_proof.go Outdated Show resolved Hide resolved
docusaurus/docs/operate/configs/relayminer_config.md Outdated Show resolved Hide resolved
okdas and others added 3 commits June 14, 2024 15:15
@okdas @Olshansk
Update x/proof/keeper/msg_server_submit_proof.go
a3ee98f 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas @Olshansk
Update docusaurus/docs/operate/configs/relayminer_config.md
b855f37 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
@okdas
Merge branch 'main' into issue/528-lean-client
10ff827
@okdas
Copy link
Member Author

okdas commented Jun 15, 2024

Merging with one flaky test still failing.

Screenshot 2024-06-14 at 5 05 26 PM

@okdas okdas merged commit ff04565 into main Jun 15, 2024
11 of 12 checks passed
@okdas okdas mentioned this pull request Jun 15, 2024
Closed
6 tasks
Olshansk added a commit that referenced this pull request Jun 15, 2024
@okdas @Olshansk
[RelayMiner] LeanClient (#567)
7d93164 
Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com>
bryanchriswhite added a commit that referenced this pull request Jun 17, 2024
@bryanchriswhite
Merge remote-tracking branch 'pokt/issues/579/feat/probabilistic-proo…
9850dcb 
…fs' into issues/579/chore/telemetry

* pokt/issues/579/feat/probabilistic-proofs:
  [RelayMiner] LeanClient (#567)
  [Session test fixes] Fix window bug and make E2E session test deterministic (#607)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@red-0ne red-0ne red-0ne approved these changes

@Olshansk Olshansk Olshansk approved these changes

Assignees

@okdas okdas

Labels
devnet devnet-test-e2e push-image CI related - pushes images to ghcr.io relayminer Changes related to the Relayminer
Projects
Shannon
Status: ✅ Done
Milestone
Shannon Beta TestNet Launch
Development

Successfully merging this pull request may close these issues.
3 participants
@okdas @red-0ne @Olshansk