Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Documentation] Cosmovisor #768

Merged
merged 21 commits into from
Sep 9, 2024
Merged

[Documentation] Cosmovisor #768

merged 21 commits into from
Sep 9, 2024

Conversation

okdas
Copy link
Member

@okdas okdas commented Aug 28, 2024

Summary

Adds documentation on how to deploy a Validator and a Full Node using Cosmovisor.

Issue

Type of change

Select one or more:

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Documentation
  • Other (specify)

Testing

  • Documentation: make docusaurus_start; only needed if you make doc changes
  • Unit Tests: make go_develop_and_test
  • LocalNet E2E Tests: make test_e2e
  • DevNet E2E Tests: Add the devnet-test-e2e label to the PR.

Sanity Checklist

  • I have tested my changes using the available tooling
  • I have commented my code
  • I have performed a self-review of my own code; both comments & source code
  • I create and reference any new tickets, if applicable
  • I have left TODOs throughout the codebase, if applicable

@okdas okdas added the documentation Improvements or additions to documentation label Aug 28, 2024
@okdas okdas added this to the Shannon Beta TestNet Launch milestone Aug 28, 2024
@okdas okdas self-assigned this Aug 28, 2024
@okdas okdas marked this pull request as ready for review August 30, 2024 18:30
@okdas okdas requested a review from Olshansk August 30, 2024 18:30
@okdas
Copy link
Member Author

okdas commented Aug 30, 2024

Note for the reviewer:

  • The URL of the script is not live until this is merged. Use https://raw.githubusercontent.com/pokt-network/poktroll/dk-docs/tools/installer/full-node.sh if you want to pull the script from this branch;
  • Similarly, the config changes are not live until the PR is merged, and the release is cut. In order for the node to start successfully, the min-gas-prices needs to be adjusted in app.toml. With this code, that will become the default value when we provision the configs. I have not performed much research on what this value should be but left a TODO_MAINNET for this and other values.

@okdas okdas mentioned this pull request Sep 4, 2024
6 tasks
@okdas
Copy link
Member Author

okdas commented Sep 4, 2024

Added cosmovisor to container images in #796.

Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some changes and leaving some comments.

Great job!

cmd/poktrolld/cmd/config.go Outdated Show resolved Hide resolved
cmd/poktrolld/cmd/config.go Outdated Show resolved Hide resolved
config.yml Outdated Show resolved Hide resolved
config.yml Outdated Show resolved Hide resolved
config.yml Outdated Show resolved Hide resolved
cmd/poktrolld/cmd/config.go Outdated Show resolved Hide resolved
tools/installer/full-node.sh Show resolved Hide resolved
@okdas okdas requested a review from Olshansk September 6, 2024 20:29
Copy link
Member

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple small comments but looks good otherwise.

// The code below changes how the default configuration files are rendered on `poktrolld init` command. This command
// is often used by the validator and full node runners to provision the configuration prior to starting the node.
// These are the values **WE WANT** participants to have. This doesn't guarantee the node runners won't adjust the values
// but it helps making sure most of them are using the following configuration.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// but it helps making sure most of them are using the following configuration.
// but it helps ensure most of them are using the same configuration; as a baseline.

// is often used by the validator and full node runners to provision the configuration prior to starting the node.
// These are the values **WE WANT** participants to have. This doesn't guarantee the node runners won't adjust the values
// but it helps making sure most of them are using the following configuration.
// Worth noting that changing these values in the future won't magically update them in the existing configuration,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not completely sure what you mean by this sentence. Please update or delete.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed the new version that I think better explains what's going on.

I'll merge it, but if you don't like it for some reason, please let me know and I'll address.

Thank you for your review!

@okdas okdas merged commit 5ee73d4 into main Sep 9, 2024
11 of 12 checks passed
bryanchriswhite added a commit that referenced this pull request Sep 16, 2024
…ke-transfer

* pokt/main:
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
  [Refactor] Replace embedded Service with ServiceId (#802)
  [Session,Service] Ensure SessionHeader and Service basic validation. (#782)
  [Tokenomics] Preparation for Global Mint Reimbursement Request (#755)
  [Quick PR][LocalNet] Turn off minimum-gas-prices (#805)
  [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801)
  [Documentation] Cosmovisor  (#768)
  [CI] Add cosmovisor to container images (#796)
  Use a descriptive error if service ID is not found (#787)
  [SessionManager] Implement off-chain proof params usage (#765)
  [SDK] Update shannon sdk dependency (#800)
  [E2E Test] Remove redundant logging (#798)
bryanchriswhite added a commit that referenced this pull request Sep 16, 2024
…actor/transfer-msg_period-param

* issues/657/feat/app-stake-transfer:
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
  [Refactor] Replace embedded Service with ServiceId (#802)
  [Session,Service] Ensure SessionHeader and Service basic validation. (#782)
  [Tokenomics] Preparation for Global Mint Reimbursement Request (#755)
  [Quick PR][LocalNet] Turn off minimum-gas-prices (#805)
  [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801)
  [Documentation] Cosmovisor  (#768)
  [CI] Add cosmovisor to container images (#796)
  Use a descriptive error if service ID is not found (#787)
  [SessionManager] Implement off-chain proof params usage (#765)
  [SDK] Update shannon sdk dependency (#800)
  [E2E Test] Remove redundant logging (#798)
bryanchriswhite added a commit that referenced this pull request Sep 16, 2024
…ues/657/chore/app-transfer-period

* issues/657/refactor/transfer-msg_period-param:
  [Tooling, Code Health] refactor: split Makefile into multiple files (#816)
  [Tooling] fix and add makefile targets (#814)
  [Docs] Add a debugging tip: using transaction hashes (#786)
  [Refactor] Replace embedded Service with ServiceId (#802)
  [Session,Service] Ensure SessionHeader and Service basic validation. (#782)
  [Tokenomics] Preparation for Global Mint Reimbursement Request (#755)
  [Quick PR][LocalNet] Turn off minimum-gas-prices (#805)
  [GATEWAY POC] A couple helpers to help deploy a PATH gateway (#801)
  [Documentation] Cosmovisor  (#768)
  [CI] Add cosmovisor to container images (#796)
  Use a descriptive error if service ID is not found (#787)
  [SessionManager] Implement off-chain proof params usage (#765)
  [SDK] Update shannon sdk dependency (#800)
  [E2E Test] Remove redundant logging (#798)
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants