Series.set() results in NotImplementedType

[MarcusJellinghaus]

Checks

• I have checked that this issue has not already been reported.
• I have confirmed this bug exists on the latest version of Polars.

Reproducible example

import polars as pl
import datetime

import os
os.environ["POLARS_VERBOSE"] = "1"

pl_series_datetime = pl.Series("date", [datetime.date(1751, 1, 1), datetime.date(1754, 1, 1)])
pl_series_datetime_sql_compliant = pl_series_datetime.set(    pl_series_datetime.dt.year() < 1753, pl.Null)
pl2 = pl_series_datetime_sql_compliant.abs()

results in NotImplementedType

Log output

Traceback (most recent call last):
  File "c:\Users\Marcus\Documents\Development\Polars_bug\bug_test.py", line 9, in <module>
    pl2 = pl_series_datetime_sql_compliant.abs()
AttributeError: 'NotImplementedType' object has no attribute 'abs'

Issue description

pl_series_datetime.set( pl_series_datetime.dt.year() < 1753, pl.Null) should return a series

Expected behavior

The result should match

expected_result = pl.Series("date", [None, datetime.date(1754, 1, 1)])
print(expected_result)

shape: (2,)
Series: 'date' [date]
[
        null
        1754-01-01
]

Installed versions

--------Version info---------
Polars:               0.20.16
Index type:           UInt32
Platform:             Windows-10-10.0.19041-SP0
Python:               3.9.0 (tags/v3.9.0:9cf6752, Oct  5 2020, 15:34:40) [MSC v.1927 64 bit (AMD64)]

----Optional dependencies----
adbc_driver_manager:  <not installed>
cloudpickle:          <not installed>
connectorx:           <not installed>
deltalake:            <not installed>
fastexcel:            <not installed>
fsspec:               <not installed>
gevent:               <not installed>
hvplot:               <not installed>
matplotlib:           <not installed>
numpy:                <not installed>
openpyxl:             <not installed>
pandas:               <not installed>
pyarrow:              <not installed>
pydantic:             <not installed>
pyiceberg:            <not installed>
pyxlsb:               <not installed>
sqlalchemy:           <not installed>
xlsx2csv:             <not installed>
xlsxwriter:           <not installed>

[MarcusJellinghaus]

Or is it an issue with the code?

[cmdlineluser]

(pl.Null in the code is "wrong" but not the problem.)

It just seems .set() is not yet supported for Date/Datetime Series.

pl_series_datetime.set(pl_series_datetime.dt.year() < 1753, None)
# NotImplemented

If we test Int:

pl_series_datetime.cast(int).set(pl_series_datetime.dt.year() < 1753, None)
# shape: (2,)
# Series: 'date' [i64]
# [
#	null
#	-78892
# ]

[MarcusJellinghaus]

Thank you for the clarification :-)

Would it make sense to support .set() for Date/DateTime Series?
As an enhancement idea?

[reswqa]

You can shift the paradigm to when-then-otherwise as set is a little anti-pattern, and will block optimizations like predicate pushdown...

pl_series_datetime = pl.Series("date", [datetime.date(1751, 1, 1), datetime.date(1754, 1, 1)])
pl.select(pl.when(pl_series_datetime.dt.year() < 1753).then(None).otherwise(pl_series_datetime))

shape: (2, 1)
┌────────────┐
│ literal    │
│ ---        │
│ date       │
╞════════════╡
│ null       │
│ 1754-01-01 │
└────────────┘