Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TraceMalloc inclusion condition is wrong: Jemalloc is used when not(allocator = "default") #17040

Closed
2 tasks done
yurivict opened this issue Jun 18, 2024 · 0 comments · Fixed by #17098
Closed
2 tasks done

TraceMalloc inclusion condition is wrong: Jemalloc is used when not(allocator = "default") #17040

yurivict opened this issue Jun 18, 2024 · 0 comments · Fixed by #17098
Assignees
@stinodego
Labels
accepted Ready for implementation bug Something isn't working build Changes that affect the build system or external dependencies P-medium Priority: medium python Related to Python Polars

Comments

@yurivict
Copy link

Checks

  • I have checked that this issue has not already been reported.
  • I have confirmed this bug exists on the latest version of Polars.

Reproducible example

n/a

Log output

No response

Issue description

At this location the condition of Jemalloc is:
#[cfg(all(debug_assertions, not(allocator = "default"), target_family = "unix",))],
which makes it used for allocator="mimalloc" as well.

Expected behavior

n/a

Installed versions

Current HEAD.
@yurivict yurivict added bug Something isn't working needs triage Awaiting prioritization by a maintainer python Related to Python Polars labels Jun 18, 2024
@stinodego stinodego added the build Changes that affect the build system or external dependencies label Jun 20, 2024
@stinodego stinodego changed the title Jemalloc inclusion condition is wrong: Jemalloc is used when not(allocator = "default") TraceMalloc inclusion condition is wrong: Jemalloc is used when not(allocator = "default") Jun 20, 2024
@stinodego stinodego removed the needs triage Awaiting prioritization by a maintainer label Jun 20, 2024
@stinodego stinodego self-assigned this Jun 20, 2024
@stinodego stinodego mentioned this issue Jun 20, 2024
Merged
@stinodego stinodego added the P-medium Priority: medium label Jun 20, 2024
@c-peters c-peters added the accepted Ready for implementation label Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stinodego stinodego

Labels
accepted Ready for implementation bug Something isn't working build Changes that affect the build system or external dependencies P-medium Priority: medium python Related to Python Polars
Projects
Backlog
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

build(python): Fix config flag for Tracemalloc pola-rs/polars
3 participants
@yurivict @stinodego @c-peters