Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation issue in normalize/name parameter from .value_counts() method #17660

Closed
diegoglozano opened this issue Jul 16, 2024 · 2 comments
Closed
Labels
documentation Improvements or additions to documentation

Comments

@diegoglozano
Copy link
Contributor

diegoglozano commented Jul 16, 2024

Description

Small issue in the documentation (both expressions and series):

if normalize is True defaults to "count", otherwise defaults to "proportion"

While it's the other way around.

Links to GH lines:
https://github.com/pola-rs/polars/blob/py-1.1.0/py-polars/polars/series/series.py#L2432
https://github.com/pola-rs/polars/blob/py-1.1.0/py-polars/polars/expr/expr.py#L9658

Link

https://docs.pola.rs/api/python/stable/reference/series/api/polars.Series.value_counts.html

@diegoglozano diegoglozano added the documentation Improvements or additions to documentation label Jul 16, 2024
@MarcoGorelli
Copy link
Collaborator

thanks @diegoglozano , fancy making a PR to fix it?

@diegoglozano
Copy link
Contributor Author

@MarcoGorelli sure! I'll try to do it today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

3 participants