Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make print snapshots more robust #191

Closed
eitsupi opened this issue May 2, 2023 · 4 comments
Closed

Make print snapshots more robust #191

eitsupi opened this issue May 2, 2023 · 4 comments

Comments

@eitsupi
Copy link
Collaborator

eitsupi commented May 2, 2023

I think the polars print is affected by the terminal size (?).
This could affect README.md regenerations and snapshot tests, so it may be worth enforcing that the print results are the same in all environments.

@etiennebacher
Copy link
Collaborator

Snapshots should all have the same width since we're using testthat 3rd edition (cf r-lib/testthat#1567). Are there some examples where the snapshots width changes?

@eitsupi
Copy link
Collaborator Author

eitsupi commented May 8, 2023

Thanks for pointing that, it seems good!

I don't know the detailed reason, but the snapshot change occurred in this PR as commented below.
#125 (comment)

@etiennebacher
Copy link
Collaborator

Is this still an issue?

@eitsupi
Copy link
Collaborator Author

eitsupi commented Jun 28, 2023

If it reoccurs, I will reopen.

@eitsupi eitsupi closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants