Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add arg maintain_order to unique() #238

Merged
merged 6 commits into from
Jun 10, 2023
Merged

Add arg maintain_order to unique() #238

merged 6 commits into from
Jun 10, 2023

Conversation

etiennebacher
Copy link
Collaborator

Follow-up of #237

eitsupi
eitsupi reviewed Jun 10, 2023
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks.

One comment about the tests.

tests/testthat/test-lazy.R Outdated Show resolved Hide resolved
tests/testthat/test-dataframe.R Outdated Show resolved Hide resolved
@sorhawell
Copy link
Collaborator

I will add some minor changes to rust code tonight

@etiennebacher etiennebacher merged commit 0c88473 into main Jun 10, 2023
@etiennebacher etiennebacher deleted the unique-maintain-order branch June 10, 2023 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi left review comments

@sorhawell sorhawell sorhawell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@etiennebacher @sorhawell @eitsupi