-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement LazyFrame$schema #250
Conversation
@sorhawell It seems that the assignment symbol is changed from |
my bad, I auto-styled all files in your previous PR, but extendr-wrappers.R should not have been styled. #251 should revert this, feel free to overrride |
@Sicheng-Pan I recommend that you work and submit PRs from individual feature branches in your fork. I got this advice from the |
looks good :) self$schema |>
result() |>
unwrap("in $column():") |>
names() however currently then err will have two times the same call-info + two times a I was contemplating to let RPolarsErr have this type struct RPolarsErr {
ctx_chain: VecDeque<Rctx>,
call: Option<Rctx>,
wherein: Option<Rctx>
} then any error can only have one call and one wherein. When deriving from another public method, the call and wherein will just be overwritten if an error. |
@vincentarelbundock this will allow us to bring back names s3 method for LazyFrame without a collect and performance drop :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Sicheng-Pan
This is awesome! I haven't time to do anything about this recently, and I probably won't have more time in the next couple months. Will probably check in then to see what's to do. Sorry... |
This PR aims to implement
schema
,columns
, anddtypes
forLazyFrame
, as requested by #243