Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replace reverse by descending in sorting functions #291

Merged
merged 3 commits into from
Jul 3, 2023
Merged

Replace reverse by descending in sorting functions #291

merged 3 commits into from
Jul 3, 2023

Conversation

etiennebacher
Copy link
Collaborator

Close #51

eitsupi
eitsupi approved these changes Jul 3, 2023
View reviewed changes
Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@etiennebacher etiennebacher merged commit 7edd8c1 into main Jul 3, 2023
@etiennebacher etiennebacher deleted the rename-arg-reverse branch July 3, 2023 07:23
@eitsupi
Copy link
Collaborator

eitsupi commented Jul 3, 2023

Sorry, I missed that we probably need to make this change on the Rust file as well.

This was referenced Jul 3, 2023
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eitsupi eitsupi eitsupi approved these changes

@sorhawell sorhawell Awaiting requested review from sorhawell

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

replace argname 'reverse' with 'descending'
2 participants
@etiennebacher @eitsupi