Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor!: Rename all classes to RPolars... #585

Merged
merged 4 commits into from
Dec 9, 2023
Merged

Conversation

eitsupi
Copy link
Collaborator

@eitsupi eitsupi commented Dec 9, 2023

Related to #554 and #149

All class names defined on the R side are also prefixed with "RPolars" for consistency.

@eitsupi eitsupi changed the title refactor!: GroupBy -> RPolarsGroupBy refactor!: Rename all classes to RPolars... Dec 9, 2023
@eitsupi eitsupi closed this Dec 9, 2023
@eitsupi eitsupi reopened this Dec 9, 2023
Copy link
Collaborator

@etiennebacher etiennebacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like I had forgotten those, thanks!

@eitsupi
Copy link
Collaborator Author

eitsupi commented Dec 9, 2023

Looks like I had forgot those, thanks!

I remembered but did not do in that PR. (That PR was already too big). No problem.

@eitsupi eitsupi merged commit 35964d9 into main Dec 9, 2023
17 checks passed
@eitsupi eitsupi deleted the rename-r-classes branch December 9, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants