Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rust-polars to 0.38.0 #865

Merged
merged 15 commits into from
Feb 29, 2024
Merged

Bump rust-polars to 0.38.0 #865

merged 15 commits into from
Feb 29, 2024

Conversation

etiennebacher
Copy link
Collaborator

Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

(pl$lit(1)$div(pl$lit(2)) == (1 / 2))$alias("1$div(2) == (1/2)"),
(pl$lit(1)$floor_div(pl$lit(2)) == (1 %/% 2))$alias("1$floor_div(2) == (1%/%2)"),
(pl$lit(1)$mod(pl$lit(2)) == (1 %% 2))$alias("1$mod(2) == (1%%2)"),
(pl$lit(1)$mod(pl$lit(-2)) != (1 %% -2))$alias("1$mod(2) != (1%%-2)"), # https://github.com/pola-rs/polars/issues/10570
(pl$lit(1)$mod(pl$lit(-2)) == (1 %% -2))$alias("1$mod(2) != (1%%-2)"),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

Copy link
Collaborator

@eitsupi eitsupi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since it passed the tests, why don't we merge it right away and update the document later?

@eitsupi eitsupi added this to the 0.15 milestone Feb 29, 2024
@eitsupi eitsupi mentioned this pull request Feb 29, 2024
@etiennebacher
Copy link
Collaborator Author

I want to update NEWS first and I'll merge then

src/rust/src/arrow_interop/to_rust.rs Outdated Show resolved Hide resolved
src/rust/src/series.rs Outdated Show resolved Hide resolved
@etiennebacher etiennebacher marked this pull request as ready for review February 29, 2024 11:52
@etiennebacher etiennebacher merged commit 5c12076 into main Feb 29, 2024
24 checks passed
@etiennebacher etiennebacher deleted the rust-polars-0.38.0 branch February 29, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants