Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-idiomatic usage in q7 #42

Closed
jbrockmendel opened this issue Apr 20, 2023 · 1 comment · Fixed by #43
Closed

Non-idiomatic usage in q7 #42

jbrockmendel opened this issue Apr 20, 2023 · 1 comment · Fixed by #43

Comments

@jbrockmendel
Copy link
Contributor

In both the pandas and modin queries:

lineitem_filtered["l_year"] = lineitem_filtered["l_shipdate"].apply(
    lambda x: x.year
)

should be

lineitem_filtered["l_year"] = lineitem_filtered["l_shipdate"].dt.year

The polars_queries version uses the analogous idiom. This made a pretty big difference locally.

@ritchie46
Copy link
Member

Thanks, the implementations were forked from bodo.ai .I assumed they would be optimized.. Could you make a PR? I can do rerun.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants