Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Queries should be expressed in SQL as well to test polars SQL coverage of TPCH #55

Closed
osawyerr opened this issue May 11, 2023 · 4 comments

Comments

@osawyerr
Copy link

osawyerr commented May 11, 2023

Hi there,

Would be worth having the queries executed in SQL to test SQL coverage of TPCH by polars and also to make it easier to write the tests.

@osawyerr osawyerr changed the title Queries in SQL Queries should be expressed in SQL as well to test polars SQL coverage of TPCH May 13, 2023
@ritchie46
Copy link
Member

Yes! We should add that for polars as well.

@stinodego
Copy link
Member

The purpose of this repo is to benchmark the engines. Polars SQL has the exact same underlying engine, so there's not much point in rewriting all the queries as SQL and running those.

I like having the queries in the native Polars API, so I'll close this as not planned for now. We can revisit if there is a concrete benefit of adding Polars SQL queries.

@stinodego stinodego closed this as not planned Won't fix, can't repro, duplicate, stale Mar 4, 2024
@osawyerr
Copy link
Author

osawyerr commented Mar 4, 2024

@stinodego the support of features in native Polars API vs Polars SQL is not 1 to 1. For example, its only recently that Polars SQL added support for LIKE queries pola-rs/polars#12399 which was missing and is a fundamental part of SQL but has been supported in the native APi for a long time. As an example LIKE is used by various TPCH queries.

Expressing the TPCH benchmark as SQL as well ensures that Polars SQL has full coverage of various SQL functionality used by analytical queries. SQL is more ubiquitous than the native Polars API.

@stinodego
Copy link
Member

If you have a feature request for a specific SQL keyword, feel free to open an issue in the Polars main repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants