Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Batch 2 of tpch queries for polars and pandas #2

Merged
merged 9 commits into from
Jun 12, 2022

Conversation

chitralverma
Copy link
Contributor

@chitralverma chitralverma commented Jun 10, 2022

  • Added code for q2 polars & pandas
  • Added code for q3 pandas
  • Added code for q4 polars & pandas
  • Added code for q5 polars & pandas

@chitralverma chitralverma changed the title Queries batch 2 Batch 2 of tpch queries for polars and pandas Jun 10, 2022
polars_queries/q4.py Outdated Show resolved Hide resolved
@ritchie46
Copy link
Member

Thanks, I think it looks good. Can I merge it?

@chitralverma
Copy link
Contributor Author

let me do q6 as well,

@ritchie46
Copy link
Member

let me do q6 as well,

Can we do that in a separate PR?

@chitralverma
Copy link
Contributor Author

let me do q6 as well,

Can we do that in a separate PR?

done already
:D

@chitralverma chitralverma marked this pull request as ready for review June 11, 2022 14:18
@chitralverma
Copy link
Contributor Author

chitralverma commented Jun 11, 2022

Added code for q2 and q6 as well.

I think thats already too much for 1 PR

@ritchie46
Copy link
Member

Thanks a lot for the effort @chitralverma!

@ritchie46 ritchie46 merged commit aa842b1 into pola-rs:main Jun 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants