Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fhir_melt loses rows #106

Closed
palmjulia opened this issue May 4, 2022 · 0 comments · Fixed by #107
Closed

fhir_melt loses rows #106

palmjulia opened this issue May 4, 2022 · 0 comments · Fixed by #107

Comments

@palmjulia
Copy link
Collaborator

When a indexed table has NA in the column that is used for melting, the corresponding row get's lost. This is not the case with current version on CRAN.

Example:

d <- data.table(id = c("[1]1", "[1]2"),
				melt_me = c("[1.1]a || [2.1]b", NA))

fhir_melt(d, columns = "melt_me", all_columns = TRUE, brackets = c("[", "]"), sep = " || ")

produces

     id melt_me resource_identifier
1: [1]1    [1]a                   1
2: [1]1    [1]b                   1
@palmjulia palmjulia linked a pull request May 10, 2022 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant