We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/ApsaraDB/galaxysql/blob/aa0b41ca6db291c0561089b5c25bd4171a969194/polardbx-calcite/src/main/java/org/apache/calcite/rel/rules/JoinCommuteRule.java#L190-L200
I think we don't need to judge it's bottom-join by using size() > 1.
size() > 1
Instead, we can just use left() instance of Join.
left() instance of Join
The text was updated successfully, but these errors were encountered:
How do you think? @Oldbread3
Sorry, something went wrong.
I don't think so. In VolcanoPlanner, the input of this logicalJoin could be a RelSubset instead of a specific Join node.
logicalJoin
agree with @chenzl25 , join could be hidden under any relNode(Project, Grouping, .etc), so that we need MetadataQuery to traverse whole sub-plan.
I got it😀
No branches or pull requests
https://github.com/ApsaraDB/galaxysql/blob/aa0b41ca6db291c0561089b5c25bd4171a969194/polardbx-calcite/src/main/java/org/apache/calcite/rel/rules/JoinCommuteRule.java#L190-L200
I think we don't need to judge it's bottom-join by using
size() > 1
.Instead, we can just use
left() instance of Join
.The text was updated successfully, but these errors were encountered: