Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TST] Add dummy dataset for pytest/local testing #262

Merged
merged 18 commits into from
Nov 19, 2020

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented Nov 16, 2020

This pull request includes:

  • a clumsy attempt to generate small images and other necessary files for "quick" local testing of code
    • (eventually could be useful for creating more unittests)
  • a test of the entire workflow using the small images
  • running pytest on circleci
  • combining coverage from pytest and ds003

@pep8speaks
Copy link

pep8speaks commented Nov 16, 2020

Hello @jdkent, Thank you for updating!

Cheers! There are no style issues detected in this Pull Request. 🍻 To test for issues locally, pip install flake8 and then run flake8 fitlins.

Comment last updated at 2020-11-19 21:52:51 UTC

@@ -33,7 +33,10 @@ install_requires =

[options.extras_require]
duecredit = duecredit
test = coverage<5
test =
coverage<5
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we update coverage at this point? Would you mind making a new branch with this where we use latset?

@jdkent
Copy link
Contributor Author

jdkent commented Nov 16, 2020

I think I need help to determine how to properly persist_to_workspace and attach_workspace, what I thought should work does not appear to (in the upload_coverage job).

@effigies
Copy link
Collaborator

I would just upload coverage separately in each job. Codecov is fine receiving multiple reports.

@codecov-io
Copy link

codecov-io commented Nov 17, 2020

Codecov Report

Merging #262 (9b1a975) into master (23c081a) will increase coverage by 6.19%.
The diff coverage is 96.81%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #262      +/-   ##
==========================================
+ Coverage   75.16%   81.35%   +6.19%     
==========================================
  Files          21       23       +2     
  Lines        1506     1459      -47     
  Branches      263      227      -36     
==========================================
+ Hits         1132     1187      +55     
+ Misses        261      244      -17     
+ Partials      113       28      -85     
Flag Coverage Δ
afni ?
ds003 60.59% <0.00%> (?)
nistats ?
pytest 67.37% <96.81%> (+54.75%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
fitlins/interfaces/bids.py 81.40% <ø> (+7.71%) ⬆️
fitlins/generate_dset.py 96.34% <96.34%> (ø)
fitlins/conftest.py 100.00% <100.00%> (ø)
fitlins/workflows/tests/test_base.py 100.00% <100.00%> (ø)
fitlins/interfaces/afni.py
fitlins/cli/run.py 83.84% <0.00%> (+1.01%) ⬆️
fitlins/interfaces/visualizations.py 65.38% <0.00%> (+3.84%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 23c081a...f608187. Read the comment docs.

@effigies
Copy link
Collaborator

Sorry, I should have noted that this was bound to conflict with the big AFNI PR. Care to merge/rebase master?

@effigies effigies merged commit 384a9c2 into poldracklab:master Nov 19, 2020
@jdkent jdkent mentioned this pull request Nov 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants