Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Make faster? #264

Merged
merged 3 commits into from
Nov 20, 2020
Merged

[CI] Make faster? #264

merged 3 commits into from
Nov 20, 2020

Conversation

jdkent
Copy link
Contributor

@jdkent jdkent commented Nov 19, 2020

I made CI take a long time in #262 , and now I'm going to try to fix it.

@effigies
Copy link
Collaborator

I think what we probably want to do is split the DB tests from the basic tests, so that they're only run on one job, rather than parameterized across estimators. It was mostly done that way because there was only one real test.

@codecov-io
Copy link

codecov-io commented Nov 20, 2020

Codecov Report

Merging #264 (151a563) into master (384a9c2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #264   +/-   ##
=======================================
  Coverage   82.95%   82.95%           
=======================================
  Files          24       24           
  Lines        1760     1760           
  Branches      273      273           
=======================================
  Hits         1460     1460           
  Misses        269      269           
  Partials       31       31           
Flag Coverage Δ
afni 61.35% <ø> (-0.23%) ⬇️
database-file 50.22% <ø> (?)
nistats 50.28% <ø> (-0.23%) ⬇️
pytest 71.25% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 384a9c2...7ab44ec. Read the comment docs.

@effigies
Copy link
Collaborator

@jdkent Sorry for jumping the gun on the last one. Is this ready to go?

@jdkent
Copy link
Contributor Author

jdkent commented Nov 20, 2020

no worries, I should mark as work in progress until I'm ready, this is good to go!

@effigies
Copy link
Collaborator

Awesome, thanks!

@effigies effigies merged commit 715bc59 into poldracklab:master Nov 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants