Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Democracy UI out of sync after cancelling a referendum #836

Closed
JoshOrndorff opened this issue Mar 24, 2019 · 6 comments
Closed

Democracy UI out of sync after cancelling a referendum #836

JoshOrndorff opened this issue Mar 24, 2019 · 6 comments
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability.
Milestone

Comments

@JoshOrndorff
Copy link
Contributor

Start a basic substrate --dev chain and connect via this UI. Use the Extrinsics tab (or any other method) to create a proposal and usher it along to a referendum. Once it is in the referendum phase, cancel it (eg. with the sudo module).

Observe that on the Democracy the referendum itself is gone but the "no available referendums" text has not re-appeared. Further, the active count is still at 1.

image

@jacogr
Copy link
Member

jacogr commented Mar 24, 2019

Weird one. Cannot reproduce at all with 5 in a row. (And 6 & 7 in inactive tabs)

Since the "no available referendums" and "active count" is not derived from each other, but rather separate storage entries. e.g. active is democracy_referendumCount.sub(democracy_nextTally) it is not an "ui doesn't refresh when it already has updated info issue".

@JoshOrndorff
Copy link
Contributor Author

JoshOrndorff commented Mar 24, 2019

Wow, thanks for such fast attention to this. Playing with more this morning using substrate 0.11.0-56332a83-x86_64-linux-gnu and polkadot-js/apps 0b36006 it seems that the "no available referendums" text now re-appears as expected. I guess that's what #837 did.

Active count remains off after canceling a referendum. It still remains off after a new proposal graduates to referendum. It finally goes back to being correct when another referendum closes (regardless of whether it passes).

Thanks again, and lmk if I can help test, or pair-program.

@JoshOrndorff
Copy link
Contributor Author

JoshOrndorff commented Mar 24, 2019

I'm not clear what you mean by "Cannot reproduce at all with 5 in a row. (And 6 & 7 in inactive tabs)"

5 proposals in a row? Inactive browser tabs running the UI?

@jacogr
Copy link
Member

jacogr commented Mar 24, 2019

Yes, indeed.

The linked PR addresses one of the issues (couldn’t reproduce it, but saw it as a possibility), where the “no active” is not displayed.

The active count (as per the picture) is a head-scratcher since it is just display of a storage entry.

@jacogr jacogr added this to the PoC-4 UI Updates milestone Apr 2, 2019
@jacogr jacogr modified the milestones: PoC-4 UI Updates, POC-5 Apr 5, 2019
@jacogr jacogr added Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability. +P3 labels Apr 10, 2019
@jacogr
Copy link
Member

jacogr commented Jan 22, 2020

This should be fixed now after the multi refresh changes on the API.

@jacogr jacogr closed this as completed Jan 22, 2020
@polkadot-js-bot
Copy link

This thread has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue if you think you have a related problem or query.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Jun 5, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Bug Tracks issues causing errors or unintended behavior, critical to fix for reliability.
Projects
None yet
Development

No branches or pull requests

3 participants