Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow importing ed25519 key type #339

Closed
ilhanu opened this issue May 26, 2020 · 5 comments
Closed

allow importing ed25519 key type #339

ilhanu opened this issue May 26, 2020 · 5 comments

Comments

@ilhanu
Copy link

ilhanu commented May 26, 2020

The value of Polkadot.js with other web-apps is getting more useful. e.g. using it for idenitification or signing.

I have started of with an ed25519 signature when kusama was still in POA mode. Since then this stuck with me, it is usable in the polkadot.js apps, here there are not limitations on using ed25519, this is different for the polkadot.js extension. The issue is to address this.

I have tried by importing the hex seed phrase[ed25519] of the account, no luck it get a different addresses. It would be great if we could add ed25519 support into the polkadot.js extension. This would save me time in re-transferring everything to a sr25519 account and probably support for more users.

@jacogr
Copy link
Member

jacogr commented May 26, 2020

Thanks for logging, will prioritize this.

@jacogr
Copy link
Member

jacogr commented May 30, 2020

After #336 we can import via JSON (another way of solving this, does not remove the need for the selector though, just an alternative)

@jacogr jacogr removed the +P3 label Aug 7, 2020
@mariopino
Copy link

Hi, same problem here using ed25519 hex address, I imported the account via JSON and got the correct address, but stilll get an error when signing a message in Polkassembly.

@jacogr
Copy link
Member

jacogr commented Sep 18, 2020

@mariopino That is an Polkassembly issue, they didn't support anything by sr from extensions before - paritytech/polkassembly#1034

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Sep 18, 2020
@jacogr
Copy link
Member

jacogr commented Oct 19, 2020

I'm going to close this one. We have compatibility with other types now via the JSON import and at this point not fully-open to make creation more confusing than it already is with more options. This may change in the future, but we are really aiming for consistency.

@jacogr jacogr closed this as completed Oct 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants